fix: Fixes reroute behavior for PR previews #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ShrimpCryptid
commented
Dec 24, 2024
There was a problem hiding this comment.
ShrimpCryptid
commented
Dec 24, 2024
There was a problem hiding this comment.
Added new unit tests from https://github.com/allen-cell-animated/timelapse-colorizer/blob/main/tests/gh_routing.test.ts
ShrimpCryptid
requested review from
meganrm and
ascibisz
and removed request for
a team
ascibisz
approved these changes
Jan 3, 2025
meganrm
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Noticed on one of my other PRs that the GH reroute behavior wasn't working correctly in the PR preview. If you refreshed while you were in the
/viewerpage, it would give you a 404 error. It turns out I forgot to copy some of the code logic from TFE that makes PR previews work.This change copies code from TFE, so I'll include links to the original code for reference.
Estimated review size: small, 10 minutes
Solution
gh_route_utils.ts.index.tsx.Type of change
Please delete options that are not relevant.
Testing and validation
I manually triggered a nightly build from this branch and confirmed that you can now refresh from the PR preview pages without getting a 404 error. This change is temporary so after today (12/24) the PR previews will be broken again until this change is merged.
Video talk-through (🔊):
2024-12-24.12-20-24.mp4