Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load disabled channels #158

Open
frasercl opened this issue Oct 26, 2023 · 0 comments
Open

Don't load disabled channels #158

frasercl opened this issue Oct 26, 2023 · 0 comments
Assignees

Comments

@frasercl
Copy link
Collaborator

Use Case

Currently, we always load all channels any time we need new volume data, despite the fact that lots of use cases keep most channels of a volume disabled. (e.g. viewing the Variance dataset in CFE, whose segmentation and contour channels - a majority of total channels - are disabled by default.)

Solution

We have a way to tell loaders which channels to load and a place to trigger new loads if we need new data. All we need to do is use them for channels as well!

As a bonus optimization, if the only change in required data is channels going from disabled to enabled, we should only load those channels, since we won't want any more data in any other channel. (This could get subtle with subregions - e.g. if enabled channels change and the subregion also shrinks, but the shrinkage won't result in a change of scale level per #157, load only the newly-enabled channels at the old subregion to avoid dimension mismatches between old and new channels.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant