-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only load enabled channels #173
Conversation
src/VolumeDrawable.ts
Outdated
@@ -513,6 +518,7 @@ export default class VolumeDrawable { | |||
// Set the color for a channel | |||
// @param {Array.<number>} colorrgb [r,g,b] | |||
updateChannelColor(channelIndex: number, colorrgb: [number, number, number]): void { | |||
console.log("update color", channelIndex, colorrgb); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this intentionally left in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup looks like this could be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Addresses #158: don't load disabled channels.
To verify:
What this PR does NOT do:
This is a relatively small change to address the "letter" of the linked issue, which falls just a bit short of the "spirit" of the issue for the following reasons: