Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Bump volume-viewer to 3.12.3 #346

Merged
merged 1 commit into from
Dec 18, 2024
Merged

refactor: Bump volume-viewer to 3.12.3 #346

merged 1 commit into from
Dec 18, 2024

Conversation

ShrimpCryptid
Copy link
Contributor

@ShrimpCryptid ShrimpCryptid commented Dec 18, 2024 •
edited
Loading

Picks up the fix for allen-cell-animated/cell-feature-explorer#223 ("volumes are blown out on load") by upgrading to volume-viewer 3.12.3.

Testing:

  1. Open branch and run locally.
  2. Open this volume, which was previously bugged: https://s3-us-west-2.amazonaws.com/bisque.allencell.org/v2.0.0/Cell-Viewer_Thumbnails/AICS-14/AICS-14_7889_atlas.json

@ShrimpCryptid ShrimpCryptid added bug Something isn't working priority Is under scheduling constraints. Should be prioritized over other outstanding PRs by reviewers. labels Dec 18, 2024
@ShrimpCryptid ShrimpCryptid self-assigned this Dec 18, 2024
@ShrimpCryptid ShrimpCryptid changed the title refactor: Bumped volume-viewer to 3.12.3 refactor: Bump volume-viewer to 3.12.3 Dec 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-18 17:22 UTC

@ShrimpCryptid ShrimpCryptid marked this pull request as ready for review December 18, 2024 00:22
@ShrimpCryptid ShrimpCryptid requested a review from a team as a code owner December 18, 2024 00:22
@ShrimpCryptid ShrimpCryptid removed the request for review from a team December 18, 2024 17:11
@jessicasyu jessicasyu self-requested a review December 18, 2024 17:14
@ShrimpCryptid ShrimpCryptid merged commit 78d8cd0 into main Dec 18, 2024
4 checks passed
@ShrimpCryptid ShrimpCryptid deleted the refactor/update-vv branch December 18, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmoynihan88 gmoynihan88 gmoynihan88 approved these changes

@jessicasyu jessicasyu jessicasyu approved these changes

@toloudis toloudis toloudis approved these changes

@frasercl frasercl Awaiting requested review from frasercl

Assignees

@ShrimpCryptid ShrimpCryptid

Labels
bug Something isn't working priority Is under scheduling constraints. Should be prioritized over other outstanding PRs by reviewers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShrimpCryptid @toloudis @jessicasyu @gmoynihan88