Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable non-distributed training and MPS support #769

Closed
wants to merge 5 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reversed logic to ensure checkpointing is unsharded for single accele…
…rator
  • Loading branch information
peter-sk committed Dec 21, 2024
commit 539f64a91e812901da4ab6648c0237aa0ca0e94c
2 changes: 1 addition & 1 deletion olmo/train.py
Original file line number Diff line number Diff line change
Expand Up @@ -1251,7 +1251,7 @@ def on_trace_ready(p):
stop_at = min(stop_at, self.global_step + extra_steps)

# Maybe save sharded checkpoint.
if self.cfg.distributed_strategy != DistributedStrategy.ddp:
if self.cfg.distributed_strategy == DistributedStrategy.fsdp:
if save_checkpoints and (
cancel_initiated
or (
Expand Down