Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Apple-188 - Section Mapping Automations #1196

Merged
merged 24 commits into from
Nov 19, 2024
Merged

Feature: Apple-188 - Section Mapping Automations #1196

merged 24 commits into from
Nov 19, 2024

Conversation

efuller
Copy link

@efuller efuller commented Nov 18, 2024 •
edited
Loading

Fixes #1199

Summary

Creates a separate table for managing section mapping automations while maintaining the overall data structure of automations.

Changes Made

  • Added the ability to the <Rule> component to hide filed types
  • Sorting is only allowed in parent table
  • The Field column has been removed from the Section Mappings table in effort to simplify

Annotation on 2024-11-19 at 14-37-52

@efuller
Update text domain
40635bb
@efuller
Set up an admin menu page for section mappings
118f041
@efuller
Set up an entry point and get React wired up
9dc0523
@efuller
Add section mappings entry point as a subfolder of admin settings
097cf63
@efuller
Add in initial mappings layout
dacf48f
@efuller
Format markup
5486fd5
@efuller
Add in a prop for hiding fields
afc622c
@efuller
Allow the value to be passed in when adding a rule
7fa3b21
@efuller
Hide the field and value columns / fields
4e4cbb8
@efuller
Add a data attribute to each role that represents its current index
fbed40e
@efuller
Split up rules between section and non-section based rules
f1ba582
@efuller
Add in ability to add new section rule
b6cbad5
@efuller
Tweak height of table nav for sections
a3ae2fe
@efuller
Rename row arrays to be more meaningful
ec45564
@efuller
Add in a check to make sure rows cannot be dragged into another table
62901dc
@efuller
i18n headings
b3b226d
@efuller
Cast to and from to numbers
37d86ed
@efuller
Remove section mapping config and files
fb33523
@efuller
Remove hideFields prop
891b751
@efuller
Add in the ability to hide field types from the field dropdown
9df0eb6
@efuller
Refactor to remove forEach as well as param from generateRule function
ca5d820
@efuller
Chores: eslint
40da581
@efuller
Update docblock
c7208e9
@efuller
Add in ability to hide columns
87b1b8c
mogmarsh
mogmarsh approved these changes Nov 19, 2024
View reviewed changes
Copy link

@mogmarsh mogmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@efuller efuller merged commit 7ff3e07 into release/2.7.0 Nov 19, 2024
11 checks passed
@efuller efuller deleted the feature/APPLE-188/section-mappings branch November 19, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mogmarsh mogmarsh mogmarsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@efuller @mogmarsh