Fix RFC compliance of identityref value types #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code is not compliant to Netconf RFC - RFC6020 https://datatracker.ietf.org/doc/html/rfc6020#section-9.10.5 Also restconf is not compliant to a similar RFC - RFC7951 https://datatracker.ietf.org/doc/html/rfc7951#section-6.8 This change fixes the XML generation tool pyang-apteryx-xml.py to generate enough information so that Netconf and Restconf can set identyref type values with the correct reference information. A basic model test.xml, was modified to set the new the XML properties on a basic type.
tony-vanderpeet
approved these changes
Jul 16, 2024
carlgsmith
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code is not compliant to Netconf RFC - RFC6020 https://datatracker.ietf.org/doc/html/rfc6020#section-9.10.5 Also restconf is not compliant to a similar RFC - RFC7951 https://datatracker.ietf.org/doc/html/rfc7951#section-6.8
This change fixes the XML generation tool pyang-apteryx-xml.py to generate enough information so that Netconf and Restconf can set identyref type values with the correct reference information.
A basic model test.xml, was modified to set the new the XML properties on a basic type.