feat(settings): add traefik log format #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey @allinurl ,
I've seen you are still very active in your repository. I've seen you have regular requests for traefik (e.g. #2368 , #1660 and #966) log format.
Here is my take at a default setting that worked for me and is according to the documentation https://doc.traefik.io/traefik/observability/access-logs/ .
Please not that I have no knowledge of GO. I just copied and adapted the existing code. So feel free to close this PR if it is not useful.
Also I don't know if you have unit tests where I could add some dummy logs for testing?
Greetings and thanks for the great tool.