Deploy Arb-Sepolia - Remove Arb-Goerli #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +12,7 @@ export async function createProfile() { | |||
|
|
|||
| const balance = await ethers.provider.getBalance(deployerAddress); | |||
|
|
|||
| const registry = registryConfig[chainId].registryProxy; | |||
| const registry = "0x4AAcca72145e1dF2aeC137E1f3C5E3D75DB8b5f3"; | |||
There was a problem hiding this comment.
^ can we change this back to fetch it from the config ?
There was a problem hiding this comment.
This doesn't exist on the config currently. We never updated the script when we updated the configs (found this out when we ran it).
Two Options:
- Just hardcode when we test creating a profile and pool after deploy on testnets.
- Add the
registryProxyto the config on all networks (has to be added to the type).
thelostone-mc
requested changes
Dec 14, 2023
thelostone-mc
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.