Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] No CryptoProvider configured for rustls for websocket #874

Closed
mattsse opened this issue Jun 12, 2024 · 0 comments · Fixed by #881
Closed

[Bug] No CryptoProvider configured for rustls for websocket #874

mattsse opened this issue Jun 12, 2024 · 0 comments · Fixed by #881
Labels
bug Something isn't working

Comments

@mattsse
Copy link
Member

mattsse commented Jun 12, 2024

Component

provider, pubsub

Describe the feature you would like

tungstenite depends on a newer version of rustls than reqwest and now disables rustls default features: snapview/tungstenite-rs#427 and expects the user to pick a backend.

hence wss connections currently fail with:

no process-level CryptoProvider available -- call CryptoProvider::install_default() before this point

we can solve this by

a) downgrading tokio-tungstenite
b) choosing a backend (ring) by depending on rustls in transport-ws
c) expect the user to do this (I don't want any issues for this)

wo could do a) until reqwest also updates its rustls dep this way we also don't pull in rustls twice

Additional context

No response

@mattsse mattsse added the enhancement New feature or request label Jun 12, 2024
@mattsse mattsse changed the title [Feature] No CryptoProvider configured for rustls for websocket [Bug] No CryptoProvider configured for rustls for websocket Jun 12, 2024
@mattsse mattsse added bug Something isn't working and removed enhancement New feature or request labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant