Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bump alloy 14ed25d #8128

Merged
merged 9 commits into from
Jun 12, 2024
Merged

chore(deps): Bump alloy 14ed25d #8128

merged 9 commits into from
Jun 12, 2024

Conversation

moricho
Copy link
Contributor

@moricho moricho commented Jun 11, 2024 •
edited
Loading

Motivation

The latest version is required at #8098.
According to the update, fixed some codes based on the following changes on the alloy side.

Solution

@moricho moricho mentioned this pull request Jun 11, 2024
Closed
3 tasks
@moricho moricho marked this pull request as draft June 11, 2024 09:15
mattsse
mattsse approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

we could replace the bool.into() with the actual enum variants, but I don't mind it

@mattsse mattsse marked this pull request as ready for review June 11, 2024 09:31
@moricho
Copy link
Contributor Author

moricho commented Jun 11, 2024

@mattsse Thanks for the review!
It appears that the execution of cast rpc --rpc-url wss://eth-mainnet.alchemyapi.io/v2/jQqqfTOQN_7A6gQEjzRYpVwXzxEBN9aj eth_chainId in the integration tests fails, but I don't have any idea why that occurs. Could you give me some advice If you have any ideas on how to solve this?

@mattsse
Copy link
Member

mattsse commented Jun 12, 2024

blocked by alloy-rs/alloy#874

@mattsse mattsse merged commit 82f0aaa into foundry-rs:master Jun 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moricho @mattsse