chore: relax a generic trait #12
Conversation
| pub struct EthEvm<DB: Database, I, PRECOMPILE = EthPrecompiles<EthEvmContext<DB>>>( | ||
| RevmEvm<EthEvmContext<DB>, I, EthInstructions<EthInterpreter, EthEvmContext<DB>>, PRECOMPILE>, | ||
| ); |
There was a problem hiding this comment.
is there no mainnet evm anymore?
isn't this intended as a wrapper around the plain L1 evm?
imo this shouldn't require this much setup
There was a problem hiding this comment.
ah I think this is so that this specific EthEvm type can be reused
There was a problem hiding this comment.
this will likely be a common use case so worth thinking how we can simplify this setup out of the box
There was a problem hiding this comment.
ah I think this is so that this specific EthEvm type can be reused
Yes, so we can change precompiles as in reth precompile example.
As the default value for Precompiles is EthPrecompile it will be the same as the previous Mainnet type.
We could use Box<dyn Precompiles> that would remove generic from it.
klkvr
force-pushed
the
rakita/new-revm
branch
from
e1a1733 to
faacdf8
Compare
Precompile generic used for
EthEvm, by default it will beEthPrecompiles