Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support spaces in the title metadata format #1227

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Support spaces in the title metadata format #1227

merged 4 commits into from
Jan 24, 2025

Conversation

epszaw
Copy link
Member

@epszaw epszaw commented Jan 21, 2025

Context

Checklist

@github-actions github-actions bot added the theme:api Javascript API related issue label Jan 21, 2025
@epszaw epszaw added the type:improvement Improvement or request label Jan 21, 2025
@epszaw epszaw marked this pull request as ready for review January 22, 2025 10:46
@epszaw epszaw requested review from delatrie and baev January 22, 2025 10:47
delatrie
delatrie requested changes Jan 23, 2025
View reviewed changes
packages/allure-js-commons/src/sdk/utils.ts Outdated Show resolved Hide resolved
packages/allure-js-commons/src/sdk/utils.ts Outdated Show resolved Hide resolved
@epszaw epszaw requested a review from delatrie January 24, 2025 10:16
delatrie
delatrie approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@delatrie delatrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice job! 👍

@epszaw epszaw merged commit a0cf483 into main Jan 24, 2025
12 checks passed
@epszaw epszaw deleted the better-title-metadata-support branch January 24, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delatrie delatrie delatrie approved these changes

@baev baev Awaiting requested review from baev

Assignees
No one assigned
Labels
theme:api Javascript API related issue type:improvement Improvement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epszaw @delatrie