Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a lot of small fixes and improvements #50

Merged
merged 3 commits into from
Jan 9, 2025
Merged

fix: a lot of small fixes and improvements #50

merged 3 commits into from
Jan 9, 2025

Conversation

@todti todti requested a review from epszaw January 6, 2025 22:19
Copy link
Member

@epszaw epszaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Whole the history row should be clickable. Now it has the pointer cursor, but direct click on the row does nothing

image

🔴 Every circle should open the related history entry. Now, clicking the chart just opens history tab.

image

Rest is fine, good job! 👍

@todti todti requested a review from epszaw January 9, 2025 10:45
@todti todti added type:bug Something isn't working type:improvement New feature or request labels Jan 9, 2025
className={styles["test-result-history-item-wrap"]}
onClick={(e) => {
e.stopPropagation();
openInNewTab(navigateUrl);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's open the history entry in the same tab when the row has been clicked. In current implementation, it doesn't make sense to have Open in new tab button when the row works in the same way

@todti todti requested a review from epszaw January 9, 2025 15:37
css: true,
};

export const sanitizeHtml = (html: string, params: IFilterXSSOptions = defaultParams) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better not to use IFilterXSSOptions directly. Keep only a single html parameter for now, we add parameters, if they'll be required

@epszaw epszaw merged commit 93960e6 into main Jan 9, 2025
4 checks passed
@epszaw epszaw deleted the some-fixes branch January 9, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants