-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: a lot of small fixes and improvements #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
className={styles["test-result-history-item-wrap"]} | ||
onClick={(e) => { | ||
e.stopPropagation(); | ||
openInNewTab(navigateUrl); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's open the history entry in the same tab when the row has been clicked. In current implementation, it doesn't make sense to have Open in new tab
button when the row works in the same way
css: true, | ||
}; | ||
|
||
export const sanitizeHtml = (html: string, params: IFilterXSSOptions = defaultParams) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better not to use IFilterXSSOptions
directly. Keep only a single html
parameter for now, we add parameters, if they'll be required
Closes:
Fixes: