Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pytest-* should only be dev dependencies #181

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Pytest-* should only be dev dependencies #181

merged 2 commits into from
Dec 12, 2024

Conversation

juggy
Copy link
Contributor

@juggy juggy commented Dec 6, 2024

No description provided.

PeterJCLaw
PeterJCLaw requested changes Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@PeterJCLaw PeterJCLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution -- you're quite right that these aren't in the right section and that they're not depended upon by the main library. However please could they be added to the dev dependencies to ensure that the tests run correctly.

@juggy juggy requested a review from PeterJCLaw December 12, 2024 16:18
PeterJCLaw
PeterJCLaw approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@PeterJCLaw PeterJCLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@PeterJCLaw PeterJCLaw merged commit a75b9e6 into alm0ra:main Dec 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJCLaw PeterJCLaw PeterJCLaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juggy @PeterJCLaw