fix: enforce data types to call our insurance API

alma · Nov 13, 2024 · b8bf29f · b8bf29f
1 parent 609ba97
commit b8bf29f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/alma/lib/Model/CustomerModel.php b/alma/lib/Model/CustomerModel.php
@@ -59,7 +59,7 @@ public function getEmail()
      */
     public function getBirthday()
     {
-        if ($this->birthday === '0000-00-00') {
+        if (strpos($this->birthday, '0000-00-00') !== false) {
             return null;
         }
 

diff --git a/alma/lib/Services/InsuranceApiService.php b/alma/lib/Services/InsuranceApiService.php
@@ -172,10 +172,10 @@ public function subscribeInsurance($subscriptionData, $order, $orderPayment = fa
         try {
             $result = $this->almaApiClient->insurance->subscription(
                 $subscriptionData,
-                $order->id,
+                strval($order->id),
                 $idTransaction,
                 $this->context->cookie->checksum,
-                $order->id_cart
+                strval($order->id_cart)
             );
 
             if (isset($result['subscriptions'])) {
@@ -184,11 +184,12 @@ public function subscribeInsurance($subscriptionData, $order, $orderPayment = fa
         } catch (\Exception  $e) {
             Logger::instance()->error(
                 sprintf(
-                    '[Alma] Error when subscribing insurance contract, message "%s", trace "%s", subscriptionData : "%s", idTransaction : "%s"',
+                    '[Alma] Error when subscribing insurance contract, message "%s", trace "%s", subscriptionData : "%s", idTransaction : "%s", API response: "%s"',
                     $e->getMessage(),
                     $e->getTraceAsString(),
                     json_encode($subscriptionData),
-                    $idTransaction
+                    $idTransaction,
+                    $e->response ? json_encode($e->response->json) : null
                 )
             );
         }