Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[insurance] Bug to add to cart if iso code prestashop isnt send #280

Conversation

Benjamin-Freoua-Alma
Copy link
Member

Reason for change

Linear task

Code changes

Set the cart on context if not for a fix on Prestashop 1.7.8.7
https://www.prestashop.com/forums/topic/1059652-this-context-cart-is-null-when-product-is-added-into-cart/

How to test

Create a customer without default address and add to cart a product with insurance

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

1 New Critical Issues (required ≤ 0)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@ClaireAlma ClaireAlma merged commit ffb8c5e into insurance Jan 8, 2024
1 of 2 checks passed
@ClaireAlma ClaireAlma deleted the feature/ECOM-1173/bug-to-add-to-cart-if-iso-code-prestashop-isnt-send branch January 8, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants