Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Remove merchant tag for in-page on Prestashop #282

Conversation

Benjamin-Freoua-Alma
Copy link
Member

Reason for change

Linear task

Code changes

Remove the check of flag in page

How to test

Update the module
Remove the flag on dashboard Alma
Check in the configuration Alma on the CMS if the the option inpage is always visible
PLUS : Check if in the DB the field ALMA_ALLOW_INPAGE is deleted

Checklist for authors and reviewers

Non applicable

Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

1 New Bugs (required ≤ 0)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link
Contributor

@joyet-simon joyet-simon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests done

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma merged commit 4fdc3ba into develop Jan 11, 2024
3 of 5 checks passed
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma deleted the feature/ECOM-1169/remove-merchant-tag-for-in-page-on-prestashop branch January 11, 2024 12:33
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma mentioned this pull request Jan 11, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants