Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Inpage on prestashop 1.6 with third party module of checkout #566

Conversation

Benjamin-Freoua-Alma
Copy link
Member

Reason for change

Linear task

Code changes

We added a stopPropagation in event click payment button on Prestashop 1.6 for fix an parent event for some third party module of checkout

How to test

As a reviewer, you are encouraged to test the PR locally.

Need to test in the merchant env

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma self-assigned this Sep 13, 2024
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma requested a review from a team as a code owner September 13, 2024 14:51
@github-actions github-actions bot added the type: bugfix Bug fix label Sep 13, 2024
Copy link

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

sonarcloud bot commented Sep 13, 2024

Copy link

❌ E2E tests have failed.
➡️ You can find the results here.

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma merged commit cafd35a into develop Sep 16, 2024
5 of 6 checks passed
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma deleted the fix/ecom-2057-ps-fix-inpage-on-prestashop-16-with-third-party-module-of branch September 16, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants