Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update github actions #574

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

alma-renovate-bot[bot]
Copy link
Contributor

@alma-renovate-bot alma-renovate-bot bot commented Sep 30, 2024

This PR contains the following updates:

Package Type Update Change
codex-/return-dispatch action major v1 -> v2
ubuntu github-runner major 22.04 -> 24.04

Release Notes

codex-/return-dispatch (codex-/return-dispatch)

v2

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

This comment has been minimized.

This comment has been minimized.

@Benjamin-Freoua-Alma
Copy link
Member

Need @alma/squad-devx validation 🙏

@alma-renovate-bot alma-renovate-bot bot changed the title chore(deps): update dependency ubuntu to v24 chore(deps): update github actions Oct 7, 2024

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Oct 8, 2024

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

sonarcloud bot commented Oct 8, 2024

@remi-zuffinetti remi-zuffinetti requested a review from a team October 8, 2024 12:30
@carine-bonnafous
Copy link
Contributor

@remi-zuffinetti if I understand correctly, python was included in ubuntu-22.04 but is no more in ubuntu-24.04 ?

@remi-zuffinetti
Copy link
Contributor

@remi-zuffinetti if I understand correctly, python was included in ubuntu-22.04 but is no more in ubuntu-24.04 ?

Not, it is still, but it is now packaged in a way that prevent directly running pip install at the system level, so that there is no conflict between packages managed by apt, and packages managed by pip.
There are plenty of way to manage that issue (create a virtualenv first, install as a user, etc..) but I preferred to rely on just using our custom installation of Python with this action, so that it's simple, and we have control over the version we used, instead of relying on updates to the runner image.
But that's a personal taste, I can take other opinions

Copy link

github-actions bot commented Oct 8, 2024

❌ E2E tests have failed.
➡️ You can find the results here.

@remi-zuffinetti remi-zuffinetti merged commit 96290f5 into develop Oct 8, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants