Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setContainer Ps Account install module #576

Conversation

Benjamin-Freoua-Alma
Copy link
Member

Reason for change

Linear task

Code changes

We set the container also in the install fonction

How to test

As a reviewer, you are encouraged to test the PR locally.

Install the module in CI without debug mode

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

Copy link

github-actions bot commented Oct 1, 2024

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

sonarcloud bot commented Oct 1, 2024

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma merged commit f6e32f5 into develop Oct 1, 2024
5 of 6 checks passed
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma deleted the fix/ecom-2112-ps-fix-setcontainer-ps-account-install-module branch October 1, 2024 15:57
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma added the skip-changelog Exclude this change from the next release changelog label Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

❌ E2E tests have failed.
➡️ You can find the results here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Exclude this change from the next release changelog type: bugfix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants