Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle Client and Api refacto for getContent #607

Draft
wants to merge 3 commits into
base: feature/ecom-2150-ps-refactor-controller-getcontent
Choose a base branch
from
Draft

feat: Handle Client and Api refacto for getContent #607

wants to merge 3 commits into from

Conversation

Benjamin-Freoua-Alma
Copy link
Member

Reason for change

Linear task

Code changes

Creation of the ClientFactory, ClientModel, ApiKeyModel to handle the api client with the good practice code

How to test

As a reviewer, you are encouraged to test the PR locally.

Use Unit Test

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@github-actions github-actions bot added the type: feature New feature label Nov 22, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 25, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
17 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma marked this pull request as ready for review November 25, 2024 18:41
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma requested a review from a team as a code owner November 25, 2024 18:41
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma marked this pull request as draft November 26, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olance olance Awaiting requested review from olance

@webaaz webaaz Awaiting requested review from webaaz

Assignees

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma

@CamilleFljt CamilleFljt

Labels
type: feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Benjamin-Freoua-Alma @CamilleFljt