Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Send the endpoint_url during the upgrade #612

Conversation

Benjamin-Freoua-Alma
Copy link
Member

Reason for change

Linear task

Code changes

  • We send the endpoint url during the update of the module 4.6.0
  • We normalized the payload returned for the gather CMS data
  • We return null in the used_fee_plans key if the array is empty

How to test

As a reviewer, you are encouraged to test the PR locally.

  • Update the module in version 4.6.0 and see if the endpoint url is sent to Alma
  • Check the data returned for Gather CMS Data without the success key
  • Check the unit test about the data returned if used_fee_plans is an array empty

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma self-assigned this Dec 2, 2024
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma requested a review from a team as a code owner December 2, 2024 16:35
@github-actions github-actions bot added the type: feature New feature label Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

⏳E2E tests are currently running.
➡️ You can follow their progression here.

Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
25.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma added the skip-changelog Exclude this change from the next release changelog label Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

❌ E2E tests have failed.
➡️ You can find the results here.

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma merged commit ba60095 into develop Dec 6, 2024
5 of 7 checks passed
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma deleted the feature/ecom-2240-ps-send-the-endpoint_url-during-the-upgrade-of-the-module branch December 6, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Exclude this change from the next release changelog type: feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants