Skip to content

Commit

Permalink
fix(node): update node version for CI and docker files
Browse files Browse the repository at this point in the history
  • Loading branch information
FranceBe committed Nov 26, 2024
1 parent e5302e4 commit 8aa2293
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

strategy:
matrix:
node-version: [12.x]
node-version: [22.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# SFCC Cartridge requires npm 6.14^ and node 12.22.12
FROM node:12
# SFCC Cartridge requires npm 10.9^ and node 22.11.0
FROM node:22

# Create app directory, and make it the current directory
RUN mkdir -p /app
Expand Down
4 changes: 2 additions & 2 deletions Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ version: 3

env:
REPOSITORY: sfcc-cartridge
# This project requires node 12.x.
# You can set RUN_IN_DOCKER env var to true to run the tasks if you don't have node 12.x installed.
# This project requires node 22.x.
# You can set RUN_IN_DOCKER env var to true to run the tasks if you don't have node 22.x installed.
RUN_IN_DOCKER: '{{ .RUN_IN_DOCKER | default "false" }}'

tasks:
Expand Down

0 comments on commit 8aa2293

Please sign in to comment.