Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALF-129 : ignore nodejs updates #123

Merged
merged 2 commits into from
Aug 9, 2024
Merged

ALF-129 : ignore nodejs updates #123

merged 2 commits into from
Aug 9, 2024

Conversation

CapMousse
Copy link
Contributor

@CapMousse CapMousse commented Jul 22, 2024 •
edited
Loading

Reason for change

Disable Renovate auto update of NodeJS
https://linear.app/almapay/issue/ALF-129/%F0%9F%8F%83-is-it-possible-to-block-node-version-to-v122212-on-the-repo-sfcc

⚠️ DO NOT MERGE ⚠️
Waiting on Node v20 tests to check if it's necessary

@CapMousse CapMousse requested a review from a team as a code owner July 22, 2024 14:33
@gdraynz
Copy link
Contributor

gdraynz commented Jul 22, 2024

You can just remove the nvm manager in renovate.json for that: it's the manager in charge of updating NodeJS.

@CapMousse
Copy link
Contributor Author

CapMousse commented Jul 22, 2024 •
edited
Loading

You can just remove the nvm manager in renovate.json for that: it's the manager in charge of updating NodeJS.

Done :)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@CapMousse
Copy link
Contributor Author

Waiting for Node v20 test

@gdraynz gdraynz merged commit 1f831b1 into main Aug 9, 2024
3 checks passed
@hyahiaoui hyahiaoui deleted the ALF-129/renovate-ignore-nodejs branch August 22, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma Benjamin-Freoua-Alma approved these changes

@gdraynz gdraynz gdraynz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CapMousse @gdraynz @Benjamin-Freoua-Alma