Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wording for due date with eligibility result localized_due_date #78

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Change wording for due date with eligibility result localized_due_date #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8969333
feature: Change wording on checkout with eligibility result
Francois-Gomis Sep 5, 2023
4ecd612
test: fix checkout test
Francois-Gomis Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cartridges/int_alma/cartridge/scripts/helpers/almaCheckoutHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ function getPaymentInstallments(plan, currencyCode) {
// on deferred capture
if (almaPaymentHelper.isAvailableForManualCapture(almaConfigHelper.isDeferredCaptureEnable(), plan.installments_count, plan.deferred_days)) {
return formatCurrency(plan.payment_plan[0].purchase_amount / 100, currencyCode) + ' ' +
Resource.msg(getPropertyCategory(plan) + '.installments.deferred_capture', 'alma', null) + ' ' +
plan.payment_plan[0].localized_due_date +
Resource.msg(getPropertyCategory(plan) + '.installments.then', 'alma', null) + ' ' +
getInstallmentCountAfterFirst(plan) +
formatCurrency(plan.payment_plan[1].purchase_amount / 100, currencyCode)
;
Expand Down
2 changes: 1 addition & 1 deletion cartridges/int_alma/cartridge/templates/resources/alma.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ alma.pay.in_x_installment.img=x{0}
alma.pay.in_x_installment.description=Pay in {0} installments with credit card
alma.pay.in_x_installment.installments=today, then
alma.pay.in_x_installment.installments.onshipment=at shipping, then
alma.pay.in_x_installment.installments.deferred_capture=at order processing, then
alma.pay.in_x_installment.installments.then=, then

alma.pay.in_x_installment_after_x_days=Pay in {0} installments in {1} days
alma.pay.in_x_installment_after_x_days.img=x{0}+{1}
Expand Down
2 changes: 1 addition & 1 deletion cartridges/int_alma/cartridge/templates/resources/alma_de_DE.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ alma.pay.in_x_installment.img=x{0}
alma.pay.in_x_installment.description=Zahlung in {0} Raten mit Kreditkarte
alma.pay.in_x_installment.installments=heute, dann
alma.pay.in_x_installment.installments.onshipment=beim Versand, dann
alma.pay.in_x_installment.installments.deferred_capture=bei der Auftragsabwicklung, dann
alma.pay.in_x_installment.installments.then=, dann

alma.pay.in_x_installment_after_x_days=Zahlung in {0} Raten in {1} Tagen
alma.pay.in_x_installment_after_x_days.img=x{0}+{1}
Expand Down
2 changes: 1 addition & 1 deletion cartridges/int_alma/cartridge/templates/resources/alma_es_ES.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ alma.pay.in_x_installment.img=x{0}
alma.pay.in_x_installment.description=Pagar en {0} plazos con tarjeta bancaria
alma.pay.in_x_installment.installments=hoy, después
alma.pay.in_x_installment.installments.onshipment=al envío, después
alma.pay.in_x_installment.installments.deferred_capture=en la tramitación del pedido, entonces
alma.pay.in_x_installment.installments.then=, entonces

alma.pay.in_x_installment_after_x_days=Pagar en {0} plazos en {1} días
alma.pay.in_x_installment_after_x_days.img=x{0}+{1}
Expand Down
2 changes: 1 addition & 1 deletion cartridges/int_alma/cartridge/templates/resources/alma_fr_FR.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ alma.pay.in_x_installment.img=x{0}
alma.pay.in_x_installment.description=Payer en {0} fois par carte de crédit
alma.pay.in_x_installment.installments=aujourd'hui, puis
alma.pay.in_x_installment.installments.onshipment=à l'expédition puis
alma.pay.in_x_installment.installments.deferred_capture=au traitement de la commande, puis
alma.pay.in_x_installment.installments.then=, puis

alma.pay.in_x_installment_after_x_days=Payer en {0} fois dans {1} jours
alma.pay.in_x_installment_after_x_days.img=x{0}+{1}
Expand Down
2 changes: 1 addition & 1 deletion cartridges/int_alma/cartridge/templates/resources/alma_it_IT.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ alma.pay.in_x_installment.img=x{0}
alma.pay.in_x_installment.description=Paga in {0} rate con carta di credito
alma.pay.in_x_installment.installments=oggi, poi
alma.pay.in_x_installment.installments.onshipment=alla spedizione, poi
alma.pay.in_x_installment.installments.deferred_capture=al momento dell'elaborazione dell'ordine, poi
alma.pay.in_x_installment.installments.then=, allora

alma.pay.in_x_installment_after_x_days=Paga in {0} rate tra {1} giorni
alma.pay.in_x_installment_after_x_days.img=x{0}+{1}
Expand Down
2 changes: 1 addition & 1 deletion cartridges/int_alma/cartridge/templates/resources/alma_nl_NL.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ alma.pay.in_x_installment.img=x{0}
alma.pay.in_x_installment.description=Betaal in {0} termijnen met kredietkaart
alma.pay.in_x_installment.installments=vandaag, dan
alma.pay.in_x_installment.installments.onshipment=bij verzending, daarna
alma.pay.in_x_installment.installments.deferred_capture=bij het verwerken van de bestelling, dan
alma.pay.in_x_installment.installments.then=, dan

alma.pay.in_x_installment_after_x_days=Betaal in {0} termijnen in {1} dagen
alma.pay.in_x_installment_after_x_days.img=x{0}+{1}
Expand Down
2 changes: 1 addition & 1 deletion cartridges/int_alma/cartridge/templates/resources/alma_pt_PT.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ alma.pay.in_x_installment.img=x{0}
alma.pay.in_x_installment.description=Pagar em {0} prestações com cartão de crédito
alma.pay.in_x_installment.installments=hoje, e depois
alma.pay.in_x_installment.installments.onshipment=na expedição, e depois
alma.pay.in_x_installment.installments.deferred_capture=no processamento da encomenda, depois
alma.pay.in_x_installment.installments.then=, então

alma.pay.in_x_installment_after_x_days=Pagar em {0} prestações em {1} dias
alma.pay.in_x_installment_after_x_days.img=x{0}+{1}
Expand Down
11 changes: 7 additions & 4 deletions test/unit/int_alma/scripts/helpers/almaCheckoutHelperTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,18 @@ var plan = {
payment_plan: [
{
customer_fee: 0,
purchase_amount: 11700
purchase_amount: 11700,
localized_due_date: 'Order processing'
},
{
customer_fee: 0,
purchase_amount: 11600
purchase_amount: 11600,
localized_due_date: '1 months later'
},
{
customer_fee: 0,
purchase_amount: 11600
purchase_amount: 11600,
localized_due_date: '2 months later'
}
]
};
Expand Down Expand Up @@ -114,7 +117,7 @@ describe('almaCheckoutHelpers', function () {
basket_cost: 'alma.credit.basket_cost',
total_cost: 'alma.credit.total_cost'
},
payment_installments: '117 alma.pay.in_x_installment.installments.deferred_capture 2x116'
payment_installments: '117 Order processingalma.pay.in_x_installment.installments.then 2x116'
});
});

Expand Down