New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pre-commit hook #79

Merged

joyet-simon merged 6 commits into develop from feature/pre-commit-hook

Sep 20, 2023

Contributor

joyet-simon commented Sep 6, 2023 •

edited

Loading

Reason for change

We need to implement pre-commit on our cartridge to improve our code.

Code changes

Implement pre-commit hook
Config pre-commit
Rectify code to pass pre-commit run

How to test

Checklist for authors and reviewers

The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
You understand the impact of this PR on existing code/features

Non applicable

The PR implements the changes asked in the referenced task / issue
The automated tests are compliant with the testing strategy
The tests are relevant, and cover the corner/error cases, not only the happy path
The changes include adequate logging and Datadog traces
Documentation is updated (API, developer documentation, ADR, Notion...)

joyet-simon added 5 commits

August 18, 2023 15:33


          add pre-commit config file

0f7b5d3


          add jshint to pre-commit config file

fd36563


          feat: pre-commit hook config

ebc5a30


          feat: pre-commit hook stylelint

d6dc262


          feat: pre-commit hook jshint

95160bd

joyet-simon self-assigned this

joyet-simon requested a review from Francois-Gomis as a code owner

September 6, 2023 08:40


          Merge branch 'develop' into feature/pre-commit-hook

a43918d

sonarcloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Francois-Gomis approved these changes

View reviewed changes

joyet-simon merged commit a5b923a into develop

3 checks passed

joyet-simon deleted the feature/pre-commit-hook branch

September 20, 2023 07:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet