Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixe some comments for the PR develop -> main #88

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Fixe some comments for the PR develop -> main #88

merged 3 commits into from
Oct 13, 2023

Conversation

joyet-simon
Copy link
Contributor

Reason for change

Linear task

Code changes

Fixe some comments for the PR develop -> main

How to test

As a reviewer, you are encouraged to test the PR locally.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@joyet-simon joyet-simon self-assigned this Oct 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

PascalLeMerrer
PascalLeMerrer reviewed Oct 12, 2023
View reviewed changes
cartridges/int_alma/cartridge/scripts/helpers/almaPaymentHelper.js
@@ -16,6 +19,8 @@ var Capture = {
description: 'Unable to capture'
}
};
var MAX_INSTALLMENTS_COUNT_FOR_PNX = 4;
var MAX_DEFERRED_DAYS_FOR_PNX = 0;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this really a maximum?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@joyet-simon joyet-simon merged commit 1e1a422 into develop Oct 13, 2023
3 checks passed
@joyet-simon joyet-simon deleted the fix/develop_pr branch October 13, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CamilleFljt CamilleFljt CamilleFljt approved these changes

@PascalLeMerrer PascalLeMerrer Awaiting requested review from PascalLeMerrer

Assignees

@joyet-simon joyet-simon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joyet-simon @PascalLeMerrer @CamilleFljt