Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather cart data from pnx and deferred payments #98

Conversation

joyet-simon
Copy link
Contributor

@joyet-simon joyet-simon commented Jun 14, 2024

Reason for change

Linear task

Code changes

Juste delete the "if" condition which used to verify if the payment methods is > 5 to add cart data in the payment object.

How to test

As a reviewer, you are encouraged to test the PR locally.
You can run unit tests.

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features

Non applicable

  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

joyet-simon and others added 4 commits March 21, 2024 15:24
Misconguration engine activation option move from `config` to `misconfig`.
…ted_option

[Security] Update deprecated Aqua scanner options
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@joyet-simon joyet-simon merged commit 3e2352b into develop Jun 17, 2024
3 checks passed
@joyet-simon joyet-simon deleted the feature/ecom-1787-sfcc-gather-cart-data-from-pnx-and-deferred-payments branch June 17, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants