Idiomatic #46
Open
Idiomatic #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alouca
reviewed
Aug 1, 2018
There was a problem hiding this comment.
moving the code from gosnmp.go to snmp.go makes it hard for me to review the changes -- can you split that diff into two? One for the changes in the code, and then one more to rename?
Also, logging in general is a good thing -- not sure what's the best way to log stuff in Go these days but I am not a huge fun of dropping it altogether.
otherwise excellent job in cleaning up the code :)
decode.go
Outdated
| } | ||
|
|
||
| //// Parses UINT16 |
There was a problem hiding this comment.
If this is no longer used, then remove the code
helper.go
Outdated
| ret.Bytes = bytes[1:] | ||
| return | ||
| } | ||
| //// parseBitString parses an ASN.1 bit string from the given byte slice and returns it. |
There was a problem hiding this comment.
Same as before, if this is no longer used, drop the code
|
Thanks! How can I split the diff as you mentioned? |
…ing the UDP connection. Also added new example_test.go file to add examples to GoDoc documentation.
Made breaking API changes that need to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed API to be more idiomatic for Gophers.