Disable test not supported by SYCL #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwyzard
force-pushed
the
disable_unsupported_SYCL_tests
branch
from
637fab2 to
db249b5
Compare
fwyzard
commented
Jan 29, 2025
There was a problem hiding this comment.
Note that most of these changes are simply due to a different indentation.
fwyzard
force-pushed
the
disable_unsupported_SYCL_tests
branch
from
db249b5 to
f89e178
Compare
fwyzard
commented
Jan 29, 2025
|
@fwyzard Change the output function to |
fwyzard
force-pushed
the
disable_unsupported_SYCL_tests
branch
from
f89e178 to
b68618e
Compare
Done
No, I haven't. |
If you don't want to solve in near time, it would be good if you open one with the description of this PR. Personally I prefer open issues for existing problem than looking in comments of closed pull requests. |
SimeonEhrig
approved these changes
Jan 30, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation of the SYCL Group functions 1 and SYCL Group algorithms library 2, calling
sycl::all_of_groupwith some threads having exited the kernel is undefined behaviour. This was confirmed during a support meeting with Intel.oneAPI has an extension to support non-uniform (sub)groups: sycl_ext_oneapi_non_uniform_groups.
The implementation of the SYCL warp functions should be extended using it; until then, we disable the failing test when using a SYCL back-end and instead print an informational message.