Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: FREE CARGO-AUDIT! #495

Closed
wants to merge 3 commits into from
Closed

ci: FREE CARGO-AUDIT! #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24a02aa
ci: FREE CARGO-AUDIT!
storopoli Nov 29, 2024
34a660a
ci: add `--locked` to `cargo-audit` install
storopoli Nov 29, 2024
710ced1
chore: Cargo.lock version 4
storopoli Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,11 @@ jobs:
with:
cache-on-failure: true

# HACK: v0.21.0 fails during dependency resolution. Remove when this is resolved
# https://github.com/rustsec/rustsec/issues/1249#issuecomment-2423257490
- name: Install cargo-audit v0.20.0
run: cargo install cargo-audit --version 0.20.0 --force
- name: Install cargo-audit
run: cargo install --locked cargo-audit --force

# HACK: not denying warnings as we depend on `yaml-rust` via `format-serde-error` which is unmaintained
# HACK: not denying warnings as we depend on `yaml-rust` via `format-serde-error`
# which is unmaintained
- name: Check for audit warnings
run: cargo audit -D warnings
Comment on lines +27 to 30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We say we're not denying warnings but then we do -D warnings?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not part of the diff but there is a line that ignores any warnings:

https://github.com/alpenlabs/strata/blob/34a660a5a84521c54613f7659f29144e4de8f3a1/.github/workflows/security.yml#L30C1-L31C32

continue-on-error: true
Expand Down
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading