Notify Router only on specific column updates #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theseanything
force-pushed
the
more-selective-router-notificatiosn
branch
2 times, most recently
from
36b17d5 to
2198875
Compare
Currently, we send a notification to the Router to update route tables whenever there is any change to the content_items (or publish_intents) tables. However, the Router only needs to update the route table when changes affect specific columns that determine the routes. This change should reduce unnecessary reloading.
theseanything
force-pushed
the
more-selective-router-notificatiosn
branch
from
2198875 to
d00c048
Compare
sihugh
reviewed
Dec 10, 2024
samsimpson1
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we send a notification to the Router to update route tables whenever there is any change to the content_items (or publish_intents) tables. However, the Router only needs to update the route table when changes affect specific columns that determine the routes.
This change should reduce unnecessary reloading.