Remove pfg scaffolding #4650
Draft
Remove pfg scaffolding #4650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntItemFactory - this helps make sure that it's always a GdsApi::Response that's presented to the factory in tests.
- We now no longer want to render anything when a content item doesn't exist, so we leave that to standard behaviour. - Our example now contains an attachment, so we don't need to specifically stub it.
- Our example now contains an attachment and details, so we don't need to stub them here.
- We're now no longer calling the content item with an optional additional hash anywhere (it was for landing page items, which now don't need it).
- Now that the initializer for the base content item doesn't have the optional params, we can simplify all super calls in derived models.
leenagupte
reviewed
Feb 20, 2025
| before do | ||
| stub_const("LandingPage::ADDITIONAL_CONTENT_PATH", "spec/fixtures") | ||
| end | ||
| subject(:landing_page) { content_item_from_factory(content_item_hash:) } |
There was a problem hiding this comment.
Why do the landing page examples need to be called through content_item_from_factory when the tests for the other document types don't?
They are also pulling examples from content schemas, but are calling described_class.new for example this is what we added in the mobbing session:
subject(:content_item) { described_class.new(content_store_response) }| @content_store_response = content_store_response | ||
| @content_store_hash = override_content_store_hash || content_store_response.to_hash | ||
| @content_store_hash = content_store_response.to_hash |
There was a problem hiding this comment.
Is content_store_hash needed now? I'm sure that before the scaffolding was added, we were just using content_store_response directly.
I think we should go back to that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove PfG scaffolding code
Why
PfG is now live, so we don't need the scaffolding that was necessary to test it before go-live. The ability to load content items from the local path has been
Relies on / Cannot be merged before: alphagov/publishing-api#3153