Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references to Technical 2nd Line #4904

Merged
merged 21 commits into from
Nov 21, 2024

Conversation

ChrisBAshton
Copy link
Contributor

Technical 2nd Line has gradually transitioned to an "in-hours on-call" model, and we're now ready to update the docs accordingly.

This PR:

  • Removes any old 2nd-line-associated docs that are clearly obsolete
  • Changes ownership of any previously 2nd-line-owned docs that may still hold value
  • Merges the "2nd line" doc into the "on call" doc (since "on call" is now all we're doing in-hours)
  • Removes any ad-hoc references to "2nd line"

Trello: https://trello.com/c/d2z5WSze/254-rebrand-2nd-line-to-simply-on-call

This stems from the pre-Kubernetes era and no longer has any value.
These alerts don't exist anymore, and also pertain to Search API
(we've largely moved to Search API V2).
It was useful once, to provide a search result if folks came
across talk of the old Carrenza VPN etc, but that's now so far
in the past this page has no value.
The linked Wiki is mostly outdated and it's not clear when the
service was last down for maintenance. Seems to be little value in
retaining this.
These aren't particularly common support tasks, and are covered
elsewhere.
We don't appear to have a Pingdom check for GOV.UK search
anymore.
We no longer have a dedicated Tech 2nd Line screen in the office.
This is all covered in the canonical "So, you're having an incident" doc
I've checked the members list and this no longer appears to be true.
We've had a number of PagerDuty alerts about failing Pingdom
checks recently, e.g.
https://governmentdigitalservice.pagerduty.com/incidents/Q2P01JX296D7O7

The alert hasn't linked to this guidance, and it doesn't seem as
though developers have gone looking for this guidance either. The
scenarios outlined in the doc are pretty unlikely, and would be
fairly straightforward to come to a conclusion on without the doc,
so there's no value in keeping this.
This brings the files in line with elasticsearch-dumps.html.md.
Whether or not that is the right channel is another question,
but we can at least do a bulk find-and-replace on those in a
future PR by consolidating them now.
Covering areas like:

- Router
- AWS infrastructure
- EKS infrastructure
- Fastly
- Env sync and backups
- Disaster recovery
- Access and controls for developer tooling
Covering areas like:

- Email
- Banner (frontend)
- Locations API / Places Manager
Covering areas like:

- Databases
- HMRC Manuals
- Transition / Bouncer
With the exception of:

- data-gov-uk-2nd-line.html.md: `A 'sysadmin' user (e.g. Technical
  2nd Line)` refers to the (still existing, as far as I'm aware)
  shared 2nd line account for CKAN.
- pingdom.html.md: `1. Select "GOV.UK Technical 2nd Line" in the`
  is still a valid instruction until we update Pingdom (perhaps
  in a follow up PR).
- tech-lead-responsibilities.html.md: `things that used to be
  drilled on Technical 2nd Line` - fine to refer to this in the
  past tense
We've now un-checked the "Email 2nd-line-support" option from all
Pingdom services, as the mailbox is no longer monitored. We'll
use Slack alerts instead.
@ChrisBAshton ChrisBAshton marked this pull request as ready for review November 21, 2024 16:02
Copy link
Contributor

@KludgeKML KludgeKML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very nice tidying along the way!

@ChrisBAshton ChrisBAshton merged commit 33be972 into main Nov 21, 2024
5 checks passed
@ChrisBAshton ChrisBAshton deleted the update-ownership-from-tech-2nd-line branch November 21, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants