Upgrade test for deprecated LibSass to node-sass@5 #5523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-5523
This is the first version that can be installed on Github Actions runner without failing thanks to it introducing support for Python 3. https://github.com/sass/node-sass/releases/tag/v5.0.0 Backport of 04b90a4 to the `support/4.x` branch Co-authored-by: Brett Kyle <[email protected]> Co-authored-by: Owen Jones <[email protected]>
romaricpascal
force-pushed
the
upgrade-libsass-test
branch
from
054af57 to
a95aaae
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-5523
domoscargin
reviewed
Nov 21, 2024
| run: | | ||
| time node-sass src/govuk/all.scss > /dev/null | ||
|
|
||
| # Check output for uncompiled Sass |
domoscargin
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first version that can be installed on Github Actions runner without failing thanks to it introducing support for Python 3.
See: https://github.com/sass/node-sass/releases/tag/v5.0.0
Backport of #5522 to the
support/4.xbranch