Content modelling/610 change name to Content Block Manager #9507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harriethw
force-pushed
the
content-modelling/610-change-name
branch
2 times, most recently
from
3490240 to
3eeb73d
Compare
Harriethw
changed the title
pezholio
approved these changes
Oct 9, 2024
| @@ -30,16 +30,16 @@ def edition_params | |||
| end | |||
|
|
|||
| def set_sentry_tags | |||
| Sentry.set_tags(engine: "content_object_store") | |||
| Sentry.set_tags(engine: "content_block_manager") | |||
There was a problem hiding this comment.
Ooh, I'll need to tweak the Sentry rules to look for the new tag instead of the old ones to ensure we still get the Slack alerts
Harriethw
force-pushed
the
content-modelling/610-change-name
branch
from
3eeb73d to
683bd3b
Compare
this includes routes, engine name, test names etc.
this is not relevant to the Content Block Manager, so we are just having the endpoint be `/content-block-manager`.
although it is not good practice to edit past migrations, we think this is safe to do as it doesn't change the actual migration, and not changing it could cause problems/confusion in the future.
Harriethw
force-pushed
the
content-modelling/610-change-name
branch
from
683bd3b to
f3e4b30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we change the name of the service from Content Object Store to Content Block Manager - and while we are here we remove
/government/adminfrom the url.Follow these steps if you are doing a Rails upgrade.