Validate landing page base paths must start with / #9629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
richardTowers
force-pushed
the
validate-landing-page-base-path
branch
from
2fb7b88
to
7f3c02e
Compare
We're being a bit sneaky with landing pages, and setting base_path to be the entire user entered slug. Unlike with other editions, where the slug gets appended to /government/something, this lets the user set the whole base path. Consequently, it's important that it starts with a slash, otherwise publishing API will reject it. As slugs can only be provided for landing pages when they're first created, leaving off the slash results in a situation the user can't recover from (the document is created with a bad slug, and there's no interface to change it).
richardTowers
force-pushed
the
validate-landing-page-base-path
branch
from
7f3c02e
to
6911c0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're being a bit sneaky with landing pages, and setting base_path to be the entire user entered slug. Unlike with other editions, where the slug gets appended to /government/something, this lets the user set the whole base path.
Consequently, it's important that it starts with a slash, otherwise publishing API will reject it. As slugs can only be provided for landing pages when they're first created, leaving off the slash results in a situation the user can't recover from (the document is created with a bad slug, and there's no interface to change it).