Add Landing Pages to the list of edition classes #9631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's getting a bit annoying not being able to find all the landing pages on the editions index page. This adds the edition class to the filter, but removes it for non-gds-admins, since landing pages are currently restricted to those users.
We're happy with LandingPages being sent to the search indexes via. publishing-api, there's no need for them to appear here too.
Now that LandingPage is part of the edition_classes list, we get tests that check link rewriting works. Which it didn't, because we hadn't put landing-pages in the edition_route_path_segments array.
richardTowers
changed the title
ChrisBAshton
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes behaviour in a couple of ways:
[internal admin link](/government/landing-pages/888)style links for landing pages, which previously wouldn't have worked.For the first use case, we remove landing pages for non-gds-admins, since other users can't do anything useful with landing pages.
The second use case isn't something I particularly care about, but there are tests for it so I had to make it work.
There's also a third side effect of adding LandingPage to the edition classes, which is that they would be sent to search-api somehow. I don't think we want or need that behaviour for landing pages, as we're already populating the search indexes via publishing-api. So I've excluded landing pages from that process.