(828) Additional workflow iterations #9841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to identify what flow a user is on when moving through the create/edit flow.
This allows us to specify the order of steps and get their next and previous steps
pezholio
force-pushed
the
content-modelling/828-additional-workflow-iterations
branch
from
8e745b0 to
9dc0a8e
Compare
This saves us from having to set it each time in our controller methods. It relies on the actions being in order, and returns the previous step for each action, unless the edition is brand new.
This was misleading, and the only difference was the `back_path`, so the two can be combined. Both `review_update_url` and `review_update` were identical URLs too, so we can remove these as well
Rather than having to manually specify where we need to redirect, we get the next action in the `SHOW_ACTIONS` constant and redirect to that step.
pezholio
force-pushed
the
content-modelling/828-additional-workflow-iterations
branch
from
9dc0a8e to
19e3d4b
Compare
Harriethw
reviewed
Jan 24, 2025
| module WorkflowHelper | ||
| def back_path(content_block_edition, current_step) | ||
| if current_step == "review" && content_block_edition.document.is_new_block? | ||
| content_block_manager.content_block_manager_content_block_documents_path |
There was a problem hiding this comment.
now I'm questing why we take users back to the documents page when reviewing a new block - it seems weird, when my browser button just takes me back to the editing form. Is it because we can't actually provide a link back to the form including the data they may have changed?
There was a problem hiding this comment.
Yeah, I thought that was weird too. I guess we could throw them back to the edit state for that block. We'd just need to be careful that we don't show them the rest of the edit flow. I think it's doable though. Lemme have a look.
There was a problem hiding this comment.
Hmmm. I think I'll merge as is. I'll make a card to pick it up at a later date.
Harriethw
approved these changes
Jan 24, 2025
pezholio
deleted the
content-modelling/828-additional-workflow-iterations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card: https://trello.com/c/eqAcYy1U/828-add-internal-and-external-change-notes-when-editing-blocks
This simplifies the workflow code further, having one source of truth for the workflow steps, adding some useful helpers to get the next/previous steps, and removing some confusing code.