Skip to content

merge master and fix conflicts #109

merge master and fix conflicts

merge master and fix conflicts #109

Triggered via push November 7, 2023 16:35
Status Success
Total duration 19s
Artifacts

dox.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

8 warnings
deploy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-python@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
the loop variable `i` is only used to index `x`: src/constraints/epigraph_squared_norm.rs#L87
warning: the loop variable `i` is only used to index `x` --> src/constraints/epigraph_squared_norm.rs:87:18 | 87 | for i in 0..nx { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` on by default help: consider using an iterator | 87 | for <item> in x.iter_mut().take(nx) { | ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~
manual implementation of an assign operation: src/constraints/epigraph_squared_norm.rs#L80
warning: manual implementation of an assign operation --> src/constraints/epigraph_squared_norm.rs:80:13 | 80 | zsol = zsol - p_z / dp_z; | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `zsol -= p_z / dp_z` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: `#[warn(clippy::assign_op_pattern)]` on by default
unneeded `return` statement: src/constraints/epigraph_squared_norm.rs#L64
warning: unneeded `return` statement --> src/constraints/epigraph_squared_norm.rs:64:18 | 64 | } | __________________^ 65 | | return; | |______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 64 - } 65 - return; 64 + } |
this expression creates a reference which is immediately dereferenced by the compiler: src/constraints/epigraph_squared_norm.rs#L42
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/constraints/epigraph_squared_norm.rs:42:58 | 42 | let norm_z_sq = matrix_operations::norm2_squared(&z); | ^^ help: change this to: `z` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
you should consider adding a `Default` implementation for `EpigraphSquaredNorm`: src/constraints/epigraph_squared_norm.rs#L14
warning: you should consider adding a `Default` implementation for `EpigraphSquaredNorm` --> src/constraints/epigraph_squared_norm.rs:14:5 | 14 | / pub fn new() -> Self { 15 | | EpigraphSquaredNorm {} 16 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 10 + impl Default for EpigraphSquaredNorm { 11 + fn default() -> Self { 12 + Self::new() 13 + } 14 + } |
this function has too many arguments (9/7): src/alm/alm_problem.rs#L135
warning: this function has too many arguments (9/7) --> src/alm/alm_problem.rs:135:5 | 135 | / pub fn new( 136 | | constraints: ConstraintsType, 137 | | alm_set_c: Option<AlmSetC>, 138 | | alm_set_y: Option<LagrangeSetY>, ... | 144 | | n2: usize, 145 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
this function has too many arguments (8/7): src/alm/alm_factory.rs#L158
warning: this function has too many arguments (8/7) --> src/alm/alm_factory.rs:158:5 | 158 | / pub fn new( 159 | | f: Cost, 160 | | df: CostGradient, 161 | | mapping_f1: Option<MappingF1>, ... | 166 | | n2: usize, 167 | | ) -> Self { | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default