Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy fixes #327

Merged
merged 3 commits into from
Oct 29, 2023

update CHANGELOG

6a9e88e
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Clippy fixes #327

update CHANGELOG
6a9e88e
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Oct 29, 2023 in 0s

clippy

3 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 3
Note 0
Help 0

Versions

  • rustc 1.73.0 (cc66ad468 2023-10-03)
  • cargo 1.73.0 (9c4383fb5 2023-08-26)
  • clippy 0.1.73 (cc66ad4 2023-10-03)

Annotations

Check warning on line 41 in src/constraints/sphere2.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler 

warning: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/constraints/sphere2.rs:41:35
   |
41 |                 x.copy_from_slice(&center);
   |                                   ^^^^^^^ help: change this to: `center`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 145 in src/alm/alm_problem.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (9/7) 

warning: this function has too many arguments (9/7)
   --> src/alm/alm_problem.rs:135:5
    |
135 | /     pub fn new(
136 | |         constraints: ConstraintsType,
137 | |         alm_set_c: Option<AlmSetC>,
138 | |         alm_set_y: Option<LagrangeSetY>,
...   |
144 | |         n2: usize,
145 | |     ) -> Self {
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 167 in src/alm/alm_factory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7) 

warning: this function has too many arguments (8/7)
   --> src/alm/alm_factory.rs:158:5
    |
158 | /     pub fn new(
159 | |         f: Cost,
160 | |         df: CostGradient,
161 | |         mapping_f1: Option<MappingF1>,
...   |
166 | |         n2: usize,
167 | |     ) -> Self {
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: `#[warn(clippy::too_many_arguments)]` on by default
View more details on GitHub Actions