Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code generation support for Sphere2 #338

Merged
merged 10 commits into from
Mar 20, 2024
Merged

Code generation support for Sphere2 #338

merged 10 commits into from
Mar 20, 2024

Conversation

alphaville
Copy link
Owner

@alphaville alphaville commented Mar 19, 2024 •
edited
Loading

Main Changes

  • Code generation support for Sphere2 in opengen
  • including Cartesian products

Associated Issues

TODOs

  • Documentation
  • All tests must pass
  • Update CHANGELOG(s)
  • Update webpage documentation
  • Bump versions (in CHANGELOG, Cargo.toml and VERSION)

@alphaville alphaville requested a review from ruairimoran March 19, 2024 15:03
ruairimoran
ruairimoran approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@ruairimoran ruairimoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. just one line left in

@alphaville
sphere2: rewrote if block for clarity
dd8b658 
additional test for Sphere2 with symbolic variable
@alphaville alphaville merged commit b5c52f9 into master Mar 20, 2024
@alphaville alphaville deleted the feature/337-codegen-sphere2 branch March 20, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruairimoran ruairimoran ruairimoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code generation for Sphere2
2 participants
@alphaville @ruairimoran