Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker image #340

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Update docker image #340

merged 4 commits into from
Aug 15, 2024

Conversation

alphaville
Copy link
Owner

@alphaville alphaville commented Mar 26, 2024 •
edited
Loading

Main Changes

This PR updates the Dockerfile. The main changes thereni are:

  • Jupyter is executed from within a virtual environment
  • Docker image creates a volume
  • Future docker images will be available on GitHub (OpEn image 0.5.0; perhaps we should call the image open-docker)

TODOs

  • Documentation
  • All tests must pass
  • Update CHANGELOG(s)
  • Update webpage documentation
  • Bump versions (in CHANGELOG, Cargo.toml and VERSION)

@alphaville
update Dockerfile
b1ffd94 
About:
Update dockerfile so that it runs
Deactivated externally-managed
TODO: use virtualenv
@alphaville
Docker runs on virtual env
aa20179
@alphaville
docker: create volume
aabbb65
@alphaville alphaville self-assigned this Mar 26, 2024
@alphaville alphaville added the docker Docker image label Mar 27, 2024
@alphaville alphaville mentioned this pull request Mar 27, 2024
Merged
5 tasks
@alphaville alphaville marked this pull request as ready for review August 15, 2024 15:45
@alphaville alphaville merged commit a22bd12 into master Aug 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alphaville alphaville

Labels
docker Docker image
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alphaville