Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting rid of warning in TCP iface #342

Merged
merged 4 commits into from
Oct 15, 2024

fix conflicts

4a97cad
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Getting rid of warning in TCP iface #342

fix conflicts
4a97cad
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Oct 14, 2024 in 0s

clippy

10 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 10
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check warning on line 161 in src/core/panoc/panoc_cache.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item without indentation

warning: doc list item without indentation
   --> src/core/panoc/panoc_cache.rs:161:9
    |
161 |     /// are satisfied.
    |         ^
    |
    = help: if this is supposed to be its own paragraph, add a blank line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
    = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
    |
161 |     ///    are satisfied.
    |         +++

Check warning on line 75 in src/core/panoc/panoc_cache.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of a legacy numeric constant

warning: usage of a legacy numeric constant
  --> src/core/panoc/panoc_cache.rs:75:29
   |
75 |             norm_gamma_fpr: std::f64::INFINITY,
   |                             ^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
   |
75 |             norm_gamma_fpr: f64::INFINITY,
   |                             ~~~~~~~~~~~~~

Check warning on line 46 in src/core/fbs/fbs_cache.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of a legacy numeric constant

warning: usage of a legacy numeric constant
  --> src/core/fbs/fbs_cache.rs:46:23
   |
46 |             norm_fpr: std::f64::INFINITY,
   |                       ^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
   |
46 |             norm_fpr: f64::INFINITY,
   |                       ~~~~~~~~~~~~~

Check warning on line 145 in src/alm/alm_problem.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (9/7)

warning: this function has too many arguments (9/7)
   --> src/alm/alm_problem.rs:135:5
    |
135 | /     pub fn new(
136 | |         constraints: ConstraintsType,
137 | |         alm_set_c: Option<AlmSetC>,
138 | |         alm_set_y: Option<LagrangeSetY>,
...   |
144 | |         n2: usize,
145 | |     ) -> Self {
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 22 in src/alm/alm_optimizer_status.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty doc comment

warning: empty doc comment
  --> src/alm/alm_optimizer_status.rs:22:5
   |
22 |     ///
   |     ^^^
   |
   = help: consider removing or filling it
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs
   = note: `#[warn(clippy::empty_docs)]` on by default

Check warning on line 735 in src/alm/alm_optimizer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of a legacy numeric constant

warning: usage of a legacy numeric constant
   --> src/alm/alm_optimizer.rs:735:71
    |
735 |                     .unwrap_or_else(|| std::time::Duration::from_secs(std::u64::MAX)),
    |                                                                       ^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
    |
735 |                     .unwrap_or_else(|| std::time::Duration::from_secs(u64::MAX)),
    |                                                                       ~~~~~~~~

Check warning on line 16 in src/alm/alm_optimizer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of a legacy numeric constant

warning: usage of a legacy numeric constant
  --> src/alm/alm_optimizer.rs:16:28
   |
16 | const SMALL_EPSILON: f64 = std::f64::EPSILON;
   |                            ^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
   |
16 | const SMALL_EPSILON: f64 = f64::EPSILON;
   |                            ~~~~~~~~~~~~

Check warning on line 167 in src/alm/alm_factory.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
   --> src/alm/alm_factory.rs:158:5
    |
158 | /     pub fn new(
159 | |         f: Cost,
160 | |         df: CostGradient,
161 | |         mapping_f1: Option<MappingF1>,
...   |
166 | |         n2: usize,
167 | |     ) -> Self {
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: `#[warn(clippy::too_many_arguments)]` on by default

Check warning on line 82 in src/alm/alm_cache.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of a legacy numeric constant

warning: usage of a legacy numeric constant
  --> src/alm/alm_cache.rs:82:27
   |
82 |             f2_norm_plus: std::f64::INFINITY,
   |                           ^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
   |
82 |             f2_norm_plus: f64::INFINITY,
   |                           ~~~~~~~~~~~~~

Check warning on line 80 in src/alm/alm_cache.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of a legacy numeric constant

warning: usage of a legacy numeric constant
  --> src/alm/alm_cache.rs:80:32
   |
80 |             delta_y_norm_plus: std::f64::INFINITY,
   |                                ^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
   = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
help: use the associated constant instead
   |
80 |             delta_y_norm_plus: f64::INFINITY,
   |                                ~~~~~~~~~~~~~