Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Modify cargo.toml for windows environments #355

Merged
merged 1 commit into from
Aug 14, 2024
Merged

🐛 Modify cargo.toml for windows environments #355

merged 1 commit into from
Aug 14, 2024

Conversation

chuoru
Copy link

@chuoru chuoru commented Aug 14, 2024 •
edited by alphaville
Loading

Main Changes

  • Modify the current posiiton of crates roots, ndarray, modcholesky to be above [target.'cfg(not(target_env = "msvc"))'.dependencies] so they can be installed when cargo build on Windows OS

Test on:

  • System/Platform: PC
  • OS: Windows 11
  • rustup version: 1.27.1
  • rustc version: 1.80.1
  • cargo version: 1.80.1
  • Python version: 3.11.4

Evidence of cargo build's output

Screenshot 2024-08-14 172921

Associated Issues

@alphaville alphaville added the rust issue related to the code Rust library label Aug 14, 2024
@alphaville alphaville changed the base branch from master to dev August 14, 2024 10:29
@alphaville
Copy link
Owner

Thanks a lot for your contribution! I will merge this now. I will release a new version of OpEn (v0.9.1) in a moment.

@alphaville alphaville merged commit c9cc773 into alphaville:dev Aug 14, 2024
7 checks passed
This was referenced Aug 14, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rust issue related to the code Rust library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't find extern crate
2 participants
@chuoru @alphaville