fix: add more check on quorum parameter

alt-research · Apr 4, 2024 · 63fc6ab · 63fc6ab
1 parent f6d7441
commit 63fc6ab
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/contracts/src/core/MachServiceManager.sol b/contracts/src/core/MachServiceManager.sol
@@ -28,7 +28,8 @@ import {
     InsufficientThreshold,
     InvalidStartIndex,
     InsufficientThresholdPercentages,
-    InvalidSender
+    InvalidSender,
+    InvalidQuorumParam
 } from "../error/Errors.sol";
 import {IMachServiceManager} from "../interfaces/IMachServiceManager.sol";
 
@@ -203,12 +204,18 @@ contract MachServiceManager is
         if (tx.origin != msg.sender) {
             revert InvalidSender();
         }
+
         // make sure the stakes against which the Batch is being confirmed are not stale
         if (alertHeader.referenceBlockNumber > block.number) {
             revert InvalidReferenceBlockNum();
         }
         bytes32 hashedHeader = hashAlertHeader(alertHeader);
 
+        // check quorum parameters
+        if (alertHeader.quorumNumbers.length != alertHeader.quorumThresholdPercentages.length) {
+            revert InvalidQuorumParam();
+        }
+
         // check the signature
         (QuorumStakeTotals memory quorumStakeTotals, bytes32 signatoryRecordHash) = checkSignatures(
             hashedHeader,

diff --git a/contracts/src/error/Errors.sol b/contracts/src/error/Errors.sol
@@ -8,6 +8,7 @@ error InvalidSender();
 error InvalidReferenceBlockNum();
 error InsufficientThreshold();
 error InsufficientThresholdPercentages();
+error InvalidQuorumParam();
 error AlreadyInAllowlist();
 error NotInAllowlist();