Refactor loop in l4d2_queue.sp to improve readability and maintainabi…

…lity
altair-sossai · Oct 30, 2024 · ab818ca · ab818ca
1 parent 74e27ec
commit ab818ca
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/addons/sourcemod/plugins/optional/l4d2_queue.smx b/addons/sourcemod/plugins/optional/l4d2_queue.smx
diff --git a/addons/sourcemod/scripting/l4d2_queue.sp b/addons/sourcemod/scripting/l4d2_queue.sp
@@ -202,8 +202,8 @@ void PrintQueue(int target)
 	char output[512];
 
 	bool isNewGame = IsNewGame();
-
-	for (int i = 0, c = 1, position = 1; i < h_Queue.Length; i++, c = c == MAX_MESSAGE_NAMES ? 1 : c + 1)
+	
+	for (int i = 0, count = 0, position = 1; i < h_Queue.Length; i++)
 	{
 		h_Queue.GetArray(i, player);
 
@@ -228,16 +228,18 @@ void PrintQueue(int target)
 		else
 			Format(output, sizeof(output), "%s %s%dº {default}%N", output, color, position, client);
 
+		count++;
 		position++;
 
-		if (c == MAX_MESSAGE_NAMES)
+		if (count == MAX_MESSAGE_NAMES)
 		{
 			if (target == 0)
 				CPrintToChatAll(output);
 			else
 				CPrintToChat(target, output);
 
 			output = "";
+			count = 0;
 		}
 	}