Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "elsewhere" option to fetch, pull and push menu #160

Merged
merged 4 commits into from
May 2, 2024

Conversation

rzikm
Copy link
Contributor

@rzikm rzikm commented May 1, 2024

Implements #139.

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.51%. Comparing base (36498f6) to head (e45cd82).

❗ Current head e45cd82 differs from pull request most recent head 4b706fb. Consider uploading reports for the commit 4b706fb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   86.33%   86.51%   +0.18%     
==========================================
  Files          56       58       +2     
  Lines        4413     4473      +60     
==========================================
+ Hits         3810     3870      +60     
  Misses        603      603              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@altsem altsem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! :)

I had some minor things just. Tested it out and seems to work!

Tests

A remote is actually set up to a temp dir when running tests, so can easily be tested!

They'd typically snapshot both the prompt and the end result.
Just to see that the command was executed is enough IMO.

#[test]
fn push_elsewhere_prompt() {
    snapshot!(TestContext::setup_clone(), "Pe");
}

#[test]
fn push_elsewhere() {
    snapshot!(TestContext::setup_clone(), "Peorigin<enter>");
}

See src/tests/push.rs or src/tests/mod.rs

Changelog

It would be nice with a changelog entry.
if You prefix your first commit with "feat: ", this will be generated automatically.

Refer to git cliff --unreleased, make test or cliff.toml

@rzikm rzikm force-pushed the elsewhere-remote branch from 2e485fa to 4b706fb Compare May 1, 2024 20:20
@rzikm
Copy link
Contributor Author

rzikm commented May 1, 2024

We should be ready for another round of review

@rzikm rzikm requested a review from altsem May 1, 2024 20:28
altsem
altsem previously approved these changes May 2, 2024
Copy link
Owner

@altsem altsem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

CHANGELOG.md Outdated

- Add "elsewhere" option to fetch, pull and push menu
- Syntax highlighting for Elixir

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I should've noted in my suggestion: this is generated when I make a release. So the commit Add changelog entry wouldn't be needed.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll squash the commits and merge it to master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I already force-pushed to remove the commit

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Ah you're fast! My merge failed because of it. Let's include all the commits then :)

@altsem altsem merged commit 7662832 into altsem:master May 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants