bugfix - avoids duplicated read IDs #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you so much for fixing this with a pull request!! very much appreciated. going to merge in a moment -- @JMF47, could you make sure this gets pushed out to BioC? |
|
In case other users encounter this the fix does not appear to be on BioC as of 1.18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
as I commented on #50, I tested yesterday the sgseq.R function and found out that the problem comes from adding 1e6 to the offset value in the interations loop, as in each iteration it was creating 1000001 reads instead of 1e6. Changing the value for 999999 does the trick to avoid extra reads with duplicated IDs.